Skip to content

Fix regression: report size delta size on PR. #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2024
Merged

Fix regression: report size delta size on PR. #172

merged 1 commit into from
Feb 21, 2024

Conversation

aentinger
Copy link

The necessary steps have in fact been documented here: https://github.com/arduino/report-size-deltas/blob/main/docs/FAQ.md#workflow-triggered-by-pull_request-event but I have overlooked them when I fixed the upload issue. With this PR the size deltas are - once again - reported within the PR.

@aentinger
Fix regression: report size delta size on PR.
4cd3c2b 
The necessary steps have in fact been documented here: https://github.com/arduino/report-size-deltas/blob/main/docs/FAQ.md#workflow-triggered-by-pull_request-event but I have overlooked them when I fixed the upload issue. With this PR the size deltas are - once again - reported within the PR.
@aentinger aentinger added type: imperfection Perceived defect in any part of project topic: infrastructure Related to project infrastructure labels Feb 21, 2024
@aentinger aentinger self-assigned this Feb 21, 2024
@github-actions GitHub Actions
Copy link

Memory usage change @ 4cd3c2b

Board flash % RAM for global variables %
arduino:samd:mkr1000 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/BasicAuthGet
flash		 % examples/BasicAuthGet
RAM for global variables		 % examples/CustomHeader
flash		 % examples/CustomHeader
RAM for global variables		 % examples/DweetGet
flash		 % examples/DweetGet
RAM for global variables		 % examples/DweetPost
flash		 % examples/DweetPost
RAM for global variables		 % examples/HueBlink
flash		 % examples/HueBlink
RAM for global variables		 % examples/PostWithHeaders
flash		 % examples/PostWithHeaders
RAM for global variables		 % examples/SimpleDelete
flash		 % examples/SimpleDelete
RAM for global variables		 % examples/SimpleGet
flash		 % examples/SimpleGet
RAM for global variables		 % examples/SimpleHttpExample
flash		 % examples/SimpleHttpExample
RAM for global variables		 % examples/SimplePost
flash		 % examples/SimplePost
RAM for global variables		 % examples/SimplePut
flash		 % examples/SimplePut
RAM for global variables		 % examples/SimpleWebSocket
flash		 % examples/SimpleWebSocket
RAM for global variables		 %
arduino:samd:mkr1000 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/BasicAuthGet<br>flash,%,examples/BasicAuthGet<br>RAM for global variables,%,examples/CustomHeader<br>flash,%,examples/CustomHeader<br>RAM for global variables,%,examples/DweetGet<br>flash,%,examples/DweetGet<br>RAM for global variables,%,examples/DweetPost<br>flash,%,examples/DweetPost<br>RAM for global variables,%,examples/HueBlink<br>flash,%,examples/HueBlink<br>RAM for global variables,%,examples/PostWithHeaders<br>flash,%,examples/PostWithHeaders<br>RAM for global variables,%,examples/SimpleDelete<br>flash,%,examples/SimpleDelete<br>RAM for global variables,%,examples/SimpleGet<br>flash,%,examples/SimpleGet<br>RAM for global variables,%,examples/SimpleHttpExample<br>flash,%,examples/SimpleHttpExample<br>RAM for global variables,%,examples/SimplePost<br>flash,%,examples/SimplePost<br>RAM for global variables,%,examples/SimplePut<br>flash,%,examples/SimplePut<br>RAM for global variables,%,examples/SimpleWebSocket<br>flash,%,examples/SimpleWebSocket<br>RAM for global variables,%
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@aentinger aentinger merged commit 7a6b39a into master Feb 21, 2024
@aentinger aentinger deleted the fix-report-size-deltas-warning branch February 21, 2024 05:58
aentinger added a commit that referenced this pull request Feb 21, 2024
@aentinger
Revert "Fix regression: report size delta size on PR. (#172)"
9f01bfe 
This reverts commit 7a6b39a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aentinger aentinger

Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aentinger